feat(desktop-ui): refactor to standalone/signal, update angular to v20, new docs #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixed and improved its documentation on the website
Owner
Author
|
docs released at https://deepkit.io/documentation/desktop-ui/getting-started |
Ventrae
reviewed
Jun 26, 2025
Comment on lines
+10
to
+26
| <dui-style /> | ||
| <dui-window normalize-style> | ||
| <dui-window-header size="small"> | ||
| <dui-window-toolbar> | ||
| <deepkit-header-logo title="API Console"></deepkit-header-logo> | ||
|
|
||
| <dui-window-toolbar-container name="main"></dui-window-toolbar-container> | ||
| <div class="top-right"> | ||
| <div> | ||
| <a routerLink="/api">OVERVIEW</a> | ||
| </div> | ||
| <deepkit-header-status-bar></deepkit-header-status-bar> | ||
| </div> | ||
| </dui-window-toolbar> | ||
| </dui-window-header> | ||
| <dui-window-content [sidebarVisible]="sidebarVisible" class="no-padding"> | ||
| <router-outlet></router-outlet> | ||
| </dui-window-content> | ||
| </dui-window> | ||
| <dui-window-toolbar-container name="main"></dui-window-toolbar-container> | ||
| <div class="top-right"> | ||
| <div> | ||
| <a routerLink="/api">OVERVIEW</a> | ||
| </div> | ||
| <deepkit-header-status-bar [client]="client.client"></deepkit-header-status-bar> | ||
| </div> | ||
| </dui-window-toolbar> | ||
| </dui-window-header> | ||
| <dui-window-content [sidebarVisible]="sidebarVisible" class="no-padding"> | ||
| <router-outlet></router-outlet> |
Collaborator
There was a problem hiding this comment.
I encourage consistent convention for self-closing tags:
- uses self-closing
- , , and use open/closing tags convention
Ventrae
reviewed
Jun 26, 2025
Comment on lines
+18
to
+22
| entryPoints = new LiveSubject<ApiEntryPoints>((subject) => { | ||
| this.api.getEntryPoints().then(v => subject.next(v)); | ||
| }); | ||
|
|
||
| public document = new LiveSubject<ApiDocument>((subject) => { | ||
| document = new LiveSubject<ApiDocument>((subject) => { |
Collaborator
There was a problem hiding this comment.
i'm pretty sure subjects are meant to be readonly in 99% of cases :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all angular code to v20, @deepkit/desktop-ui is now standalone/signal based.